Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A administrate
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 96
    • Issues 96
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 32
    • Merge requests 32
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • thoughtbot, inc.
  • administrate
  • Issues
  • #1598
Closed
Open
Issue created Apr 02, 2020 by Pablo Brasero@pablobmContributor

Ensure that spec names describe their intent

There are several spec files whose name doesn't reflect what they are trying to describe. Instead, they refer to sections of the example website where the spec'd behaviour happens to take place.

For example:

  • spec/features/log_entries_form_spec.rb describes select fields.
  • spec/features/line_items_spec.rb describes index, edit, and new pages.
  • spec/features/orders_form_spec.rb describes select fields (again), belongs_to associations, has_many associations, and datetime fields.

As a result, sometimes I find myself looking for a spec example and not remembering where to find it.

We should reorganise these specs so that they refer to the functionality that they are describing.

Assignee
Assign to
Time tracking