Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • J JVFloatLabeledTextField
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 26
    • Issues 26
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Jared Verdi
  • JVFloatLabeledTextField
  • Merge requests
  • !205

Fix iOS 13 floating label default font

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/gonzula/master into master Sep 17, 2019
  • Overview 4
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: gonzula

In iOS 13 (GM) the text field default font name is .SFUI-Regular which for some reason, when used in +fontWithName:size: returns a Times New Roman UIFont.

This can be noted in the playground: playground font name bug

and in an iOS app results in the floating label using Times New Roman as default font: ios app font bug

Thus, +fontWithName:size: is not safe to create a copy of the font. In this PR I changed those calls to use -fontWithSize:(CGFloat)fontSize which fixes the problem:

ios app font fix

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/gonzula/master