Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • J JVFloatLabeledTextField
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 26
    • Issues 26
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Jared Verdi
  • JVFloatLabeledTextField
  • Merge requests
  • !178

Feature/multiline placeholder support

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Matthew Carr requested to merge github/fork/MattCarr147/feature/MultilinePlaceholderSupport into master Sep 15, 2017
  • Overview 4
  • Commits 2
  • Pipelines 0
  • Changes 8

This is a pull request to resolve #177 (closed).

Notes:

  • I've only been able to test this using the simulator so far.
  • I'm aware that this bug exists in edge case behaviour and so have prioritised standard use where possible.
  • I began working on a fix using Xcode 9 (GM). I had to 'Update to Recommended Settings' in order for the project to build in the new version of Xcode. All of these changes were added in a separate commit.

As mentioned, I've tried to minimise the impact of this change on standard use of the library, as far as I can tell standard behaviour is the same with or without the fix:

Demo Project (no changes made):

Without Fix With Fix
demoprojectwithoutfix default demoprojectwithfix default

Demo Project (multiline placeholder):

Without Fix With Fix
demoprojectwithoutfix default demoprojectwithfix default

The fix is, of course, targeted at cases where scrollEnabled = FALSE. An example can be seen below:

Demo Project (multiline placeholder and scrollEnabled=false)

Note that the auto layout constraints used in the demo project do not work particularly well when descriptionField.scrollEnabled=false, hence the odd layouts.

Without Fix With Fix
demoprojectwithoutfix scrolldisabled demoprojectwithfix scrolldisabled
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/MattCarr147/feature/MultilinePlaceholderSupport