Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Issues
  • #5307
Closed
Open
Issue created Oct 05, 2018 by Administrator@rootContributor

react-error-overlay not open up file in windows (vscode)

Created by: sercangurbuz

Is this a bug report?

I hope so

Did you try recovering your dependencies?

Yes

Which terms did you search for in User Guide?

WINDOWS_FILE_NAME_WHITELIST ,windows,react-error-overlay

Environment

Windows10,vscode

Steps to Reproduce

  1. give runtime error in any component
  2. try to locate the file clicking the error on overlay expecting vscode to open up the relevant file

Expected Behavior

I expect vscode to bring up the file which error is thrown in.

Actual Behavior

Absolute file path sent from webpackdevClient is considered as insecure and stuck in regex check WINDOWS_FILE_NAME_WHITELIST in react-error-overlay project.

Reproducible Demo

Say that ,File path is like below D:/Samples/new/src/App.js

is not valid according to regex /^[\p{L}0-9/.-_\]+$/u @acdlite

but if you remove the partition specifier from path like below it works and open up the file

/Samples/new/src/App.js

or

^[a-zA-Z]:/[\p{L}0-9/.-_\]+$

this regex helps accepting the partition specifier

Assignee
Assign to
Time tracking