Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • V vedaseg
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 6
    • Issues 6
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Media-Smart
  • vedaseg
  • Issues
  • #62
Closed
Open
Issue created Nov 30, 2022 by Agnes-U@Agnes-U

Suggest to loosen the dependency on albumentations

Hi, your project vedaseg requires "albumentations==0.4.1" in its dependency. After analyzing the source code, we found that some other versions of albumentations can also be suitable without affecting your project, i.e., albumentations 0.4.0. Therefore, we suggest to loosen the dependency on albumentations from "albumentations==0.4.1" to "albumentations>=0.4.0,<=0.4.1" to avoid any possible conflict for importing more packages or for downstream projects that may use vedaseg.

May I pull a request to loosen the dependency on albumentations?

By the way, could you please tell us whether such dependency analysis may be potentially helpful for maintaining dependencies easier during your development?



For your reference, here are details in our analysis.

Your project vedaseg(commit id: fa4ff422) directly uses 5 APIs from package albumentations.

albumentations.augmentations.functional.scale, albumentations.core.transforms_interface.to_tuple, albumentations.core.transforms_interface.DualTransform.__init__, albumentations.core.composition.Compose.__init__, albumentations.augmentations.transforms.PadIfNeeded.__init__

From which, 15 functions are then indirectly called, including 14 albumentations's internal APIs and 1 outsider APIs, as follows (neglecting some repeated function occurrences).

[/Media-Smart/vedaseg]
+--albumentations.augmentations.functional.scale
|      +--albumentations.augmentations.functional.resize
|      |      +--albumentations.augmentations.functional._maybe_process_in_chunks
|      |      |      +--albumentations.augmentations.functional.get_num_channels
|      |      |      +--numpy.dstack
+--albumentations.core.transforms_interface.to_tuple
+--albumentations.core.transforms_interface.DualTransform.__init__
|      +--albumentations.core.transforms_interface.BasicTransform.__init__
+--albumentations.core.composition.Compose.__init__
|      +--albumentations.core.composition.BaseCompose.__init__
|      |      +--albumentations.core.composition.Transforms.__init__
|      |      |      +--albumentations.core.composition.Transforms._find_dual_start_end
|      |      |      |      +--albumentations.core.composition.Transforms._find_dual_start_end
|      +--albumentations.augmentations.bbox_utils.BboxProcessor.__init__
|      |      +--albumentations.core.utils.DataProcessor.__init__
|      +--albumentations.core.composition.BboxParams.__init__
|      |      +--albumentations.core.utils.Params.__init__
|      +--albumentations.augmentations.keypoints_utils.KeypointsProcessor.__init__
|      |      +--albumentations.core.utils.DataProcessor.__init__
|      +--albumentations.core.composition.KeypointParams.__init__
|      |      +--albumentations.core.utils.Params.__init__
|      +--albumentations.core.composition.BaseCompose.add_targets
+--albumentations.augmentations.transforms.PadIfNeeded.__init__
|      +--albumentations.core.transforms_interface.BasicTransform.__init__

We scan albumentations's versions among [0.4.0] and 0.4.1, the changing functions (diffs being listed below) have none intersection with any function or API we mentioned above (either directly or indirectly called by this project).

diff: 0.4.1(original) 0.4.0
['albumentations.augmentations.transforms.Resize.apply_to_keypoint', 'albumentations.augmentations.transforms.RandomGridShuffle.__init__', 'albumentations.augmentations.transforms.RandomGridShuffle', 'albumentations.augmentations.transforms.Resize']

As for other packages, the APIs of @outside_package_name are called by albumentations in the call graph and the dependencies on these packages also stay the same in our suggested versions, thus avoiding any outside conflict.

Therefore, we believe that it is quite safe to loose your dependency on albumentations from "albumentations==0.4.1" to "albumentations>=0.4.0,<=0.4.1". This will improve the applicability of vedaseg and reduce the possibility of any further dependency conflict with other projects/packages.

Assignee
Assign to
Time tracking