Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Issues
  • #5
Closed
Open
Issue created Nov 27, 2014 by Derek Bruening@derekbrueningContributor

i4-make-review

From derek.br...@gmail.com on February 12, 2009 11:20:53

issue #4 (closed): set up automated code reviews

  • moved diff automation from /core/Makefile to /Makefile
  • replaced scp with svn commit to /reviews///
  • replaced email with log message for auto-Issue
  • removed diff numbers
  • removed manually adding new files to the diff since svn does that for us
  • removed per-file commit message support

stats: 570 diff lines Makefile | 120 +++++++++++++++++++++++++++---! Makefile.custom_build | 26 !!!!!! core/Makefile | 173 -------------------------------------------!! core/Makefile.custom_build | 80 -------------------- make/compiler.mk | 3 5 files changed, 107 insertions(+), 260 deletions(-), 35 modifications(!)

Original issue: http://code.google.com/p/dynamorio/issues/detail?id=5

Assignee
Assign to
Time tracking