Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Issues
  • #4338
Closed
Open
Issue created Jun 26, 2020 by Derek Bruening@derekbrueningContributor

Eliminate include of system signal.h from core/ builds

We've had various define conflicts and problems in the past from the system signal.h conflicting with kernel-level or other defines we need inside DR. Today we still include signal.h, but we have our own distinctly-named types like kernel_sigcontext_t to avoid conflicts. But we still have some shared types, including on aarch64 where struct fpsimd_context ends up coming from the system includes. Xref PR #4325 where I added it to our own sigcontext.h to support targeting aarch64 on x86, but it would better to rename the type, and even better to eliminate the signal.h include. Xref the discussion at https://github.com/DynamoRIO/dynamorio/pull/4325#discussion_r446257978

Assignee
Assign to
Time tracking