Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Issues
  • #3588
Closed
Open
Issue created May 01, 2019 by Hendrik Greving@hgreving2304Contributor

Convert NOCHECKIN from up-front suite failure to test failure to unblock diagnosing build/test issues on CI

https://github.com/DynamoRIO/dynamorio/wiki/Code-Style suggests to mark temporary code unsuited for committing with NOCHECKIN. However, if you do that, the builds fail, making it unsuitable for testing e.g. on Travis.

If NOCHECKIN would prevent the code being able to merge (pre-commit hook on Travis?), it would make sense. Otherwise I'm not sure how the NOCHECKIN hook could be used for as long as we're using Travis.

Assignee
Assign to
Time tracking