Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Issues
  • #2900
Closed
Open
Issue created Mar 26, 2018 by Administrator@rootContributor

Typo in ARM opnd_compute_address_priv caught by GCC 7.3.0

Created by: egrimley

With the GCC in Debian unstable I got this warning:

/.../dynamorio/core/arch/opnd_shared.c:1920:72: error: ?: using integer constants in boolean context [-Werror=int-in-bool-context]
                 (TEST(EFLAGS_C, mc->cpsr) ? (1 << (sizeof(reg_t)*8-1)) : 0);
                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~

GCC deserves a pat on the head for this, because it seems to have caught a real bug: the || at the end of line 1919 should be a |, I think. What the code seems to be doing is computing the effective address when RRX is used in an address calculation: a very weird thing to do, so it's not surprising if it was never tested. (Is there a place where a test for this could easily be added? Not worth adding a new top-level test just for this.)

Assignee
Assign to
Time tracking