Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Issues
  • #1246
Closed
Open
Issue created Nov 28, 2014 by Derek Bruening@derekbrueningContributor

Merge windows and unix partial map test cases.

From peter.goodman on August 14, 2013 16:07:44

What is the problem to solve? Why is it important? Provide some context for those unfamiliar with the details of the system. Make a cross-platform partial module map test case. Right now suite/tests/win32/partial_map.c and suite/tests/client-interface/partial_module_map.c both test for partial module loads (e.g. when the app is only trying to parse ELF headers, not do a full dlopen). What are the possible approaches to solving the problem? Merge the test cases. Which approach is being taken and why? Currently the tests are separate. The Windows test appears rather complex, whereas the unix test is fairly simple. I lack experience with Windows, and so I have opted for the simpler approach of keeping the tests separate for now. Any interesting details or challenges of the implementation? Perhaps the implementation need only be as complex as a big #ifdef that chooses either the existing windows or unix test code depending on the build configuration.

Original issue: http://code.google.com/p/dynamorio/issues/detail?id=1246

Assignee
Assign to
Time tracking